Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env: remove karma(continue #628) #630

Merged
merged 51 commits into from
Sep 1, 2021
Merged

env: remove karma(continue #628) #630

merged 51 commits into from
Sep 1, 2021

Conversation

lja1018
Copy link
Contributor

@lja1018 lja1018 commented Aug 31, 2021 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • apply jest
    • cropzone.spec.js
    • drawingMode.spec.js
    • filter.spec.js
    • flip.spec.js
    • graphics.spec.js
    • history.spec.js
    • icon.spec.js
    • imageEditor.spec.js
    • invoker.spec.js
    • line.spec.js
    • promiseApi.spec.js
    • resize.spec.js
    • rotation.spec.js
    • selectionModifyHelper.spec.js
    • shape.spec.js
    • text.spec.js
    • theme.spec.js
    • ui.spec.js
    • uiRange.spec.js
    • zoom.spec.js

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

lja1018 added 30 commits August 11, 2021 17:59
@lja1018
env: remove dependencies related karma
250f3fe 
* remove unused dependency `simulant`
@lja1018
chore: remove directory from .gitignore
85c9416
@lja1018
chore: remove karma from bower.json
ec7a5b8
@lja1018
chore: remove jasmine, jquery from .eslintrc.js
ede34c0
@lja1018
env: add jest
5c1297f
@lja1018
env: update dependencies related eslint
e059086
@lja1018
chore: remove eslint-loader in webpack.config.js
ad656de
@lja1018
chore: remove karma.config.js
ef054a8
@lja1018
env: add eslint-plugin-jest
f518530
@lja1018
chore: add eslint-plugin-jest config to .eslintrc.js
0c9fe5f
@lja1018
chore: update test command
84bb6e9
@lja1018
env: add jest config
69a635d 
* add `jest-esm-transformer` dependency
@lja1018
env: add jest-canvas-mock
e37cab9
@lja1018
fix: resolve webpack alias
83917b5
@lja1018
refactor: remove globals in .eslintrc.js
d969061
@lja1018
refactor: remove fabric in webpack externals
185f8e4 
* revert #234
@lja1018
refactor: apply jest to cropper.spec.js
026eb97
@lja1018
env: add jest-svg-transformer
4ecea87
@lja1018
refactor: add dot-notation rule to .eslintrc.js
1890fed 
* change `max-nested-callbacks` rule's max option to 5
@lja1018
refactor: apply jest to action.spec.js
7210c62 
* add `no-undefined` rule
@lja1018
refactor: apply jest to arrowLine.spec.js
fe92253
@lja1018
env: add file mocking to jest
4d46e65
@lja1018
refactor: apply jest to command.spec.js
c7688a6
@lja1018
refactor: apply code review
485096f 
* apply `toMatchObject`
* apply `toMatchSnapshot`
* add `jest/expect-expect` rules to `.eslintrc.js`
@lja1018
refactor: apply code review 2
d5b891d 
* apply `async`, `await` instead `return Promise`
* add `parserOptions.ecmaVersion` to `.eslintrc.js`
@lja1018
refactor: apply jest to cropzone.spec.js
8a05513
@lja1018
refactor: apply jest to drawingMode.spec.js
4f8e550
@lja1018
refactor: apply jest to filter.spec.js
1fde22d
@lja1018
refactor: apply async, await instead return Promise
3710cce
@lja1018
refactor: apply jest to flip.spec.js
4df1226
lja1018 added 20 commits August 27, 2021 14:08
@lja1018
refactor: apply jest to graphics.spec.js
d66c672
@lja1018
refactor: apply jest to history.spec.js
7e2b61d
@lja1018
refactor: apply jest to icon.spec.js
c34e09e
@lja1018
refactor: apply jest to imageEditor.spec.js
241eeac
@lja1018
refactor: remove unused env
4f38fa4
@lja1018
refactor: change isFunction to use typeof
480554d 
* apply to `invoker.js`
@lja1018
refactor: apply jest to invoker.spec.js
d614e15
@lja1018
refactor: apply jest to line.spec.js
31a0828
@lja1018
refactor: apply jest to promiseApi.spec.js
d0868be
@lja1018
refactor: apply jest to resize.spec.js
72b6b83
@lja1018
refactor: apply jest to rotation.spec.js
9945c87
@lja1018
refactor: apply jest to selectionModifyHelper.spec.js
315250d
@lja1018
refactor: apply jest to shape.spec.js
c326f65
@lja1018
refactor: apply jest to text.spec.js
a41ae1d
@lja1018
refactor: apply jest to theme.spec.js
75178b8
@lja1018
refactor: apply jest to ui.spec.js
6b4b342
@lja1018
refactor: apply jest to uiRange.spec.js
d17bfc9
@lja1018
refactor: apply jest to zoom.spec.js
2a3117d
@lja1018
Merge branch 'master' into env/remove-karma(continue)
6e3189b 
# Conflicts:
#	apps/image-editor/tests/cropzone.spec.js
#	apps/image-editor/tests/flip.spec.js
#	apps/image-editor/tests/graphics.spec.js
#	apps/image-editor/tests/icon.spec.js
#	apps/image-editor/tests/index.js
#	apps/image-editor/tests/line.spec.js
#	apps/image-editor/tests/resize.spec.js
#	apps/image-editor/tests/rotation.spec.js
#	apps/image-editor/tests/selectionModifyHelper.spec.js
#	apps/image-editor/tests/shape.spec.js
#	apps/image-editor/tests/text.spec.js
@lja1018
refactor: change to toMatchObject from expect.objectContaining
12223b6
jwlee1108
jwlee1108 reviewed Aug 31, 2021
View reviewed changes
Copy link

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

apps/image-editor/src/js/util.js Show resolved Hide resolved
apps/image-editor/tests/__snapshots__/shape.spec.js.snap Show resolved Hide resolved
adhrinae
adhrinae approved these changes Aug 31, 2021
View reviewed changes
Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다. 고생하셨어요.

apps/image-editor/src/js/util.js Show resolved Hide resolved
apps/image-editor/tests/__snapshots__/shape.spec.js.snap Show resolved Hide resolved
apps/image-editor/tests/cropzone.spec.js Show resolved Hide resolved
apps/image-editor/tests/imageEditor.spec.js Show resolved Hide resolved
apps/image-editor/tests/ui.spec.js Outdated Show resolved Hide resolved
apps/image-editor/tests/ui.spec.js Outdated Show resolved Hide resolved
@lja1018 lja1018 merged commit 763f712 into master Sep 1, 2021
@lja1018 lja1018 deleted the env/remove-karma(continue) branch September 1, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwlee1108 jwlee1108 jwlee1108 left review comments

@adhrinae adhrinae adhrinae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lja1018 @adhrinae @jwlee1108