Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not uncheck filter's checkbox when reset image [fix #552] #570

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

lja1018
Copy link
Contributor

@lja1018 lja1018 commented Apr 1, 2021

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Fix a bug that does not uncheck the filter's check box when a reset or image is loaded after applying the filter

  • AS-IS

    • 화면-기록-2021-04-01-오후-5 07 09
  • TO-BE

    • Uncheck the filter box when resetting or loading images after applying the filter.
  • Solution

    • Add logic to uncheck all filter check boxes when reset or image load

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Member

@jung-han jung-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완료입니다

Copy link
Member

@heenakwag heenakwag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@lja1018 lja1018 merged commit 1d81c6c into master Apr 8, 2021
@lja1018 lja1018 deleted the fix/not-uncheck-filter-checkbox-when-init-image branch April 8, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants