fix: free line position middle commit for prototype fix #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsik-yoo
reviewed
Dec 3, 2019
src/js/graphics.js
Outdated
| @@ -996,7 +996,11 @@ class Graphics { | |||
| * @private | |||
| */ | |||
| _onPathCreated(obj) { | |||
| obj.path.set(consts.fObjectOptions.SELECTION_STYLE); | |||
| const objCenter = obj.path.getCenterPoint(); | |||
There was a problem hiding this comment.
넵 그렇군요. 적용하겠습니다. 감사합니다.
src/js/graphics.js
Outdated
| @@ -996,7 +996,11 @@ class Graphics { | |||
| * @private | |||
| */ | |||
| _onPathCreated(obj) { | |||
| obj.path.set(consts.fObjectOptions.SELECTION_STYLE); | |||
| const objCenter = obj.path.getCenterPoint(); | |||
| obj.path.set(extend({}, consts.fObjectOptions.SELECTION_STYLE, { | |||
There was a problem hiding this comment.
extend의 첫번째 파라미터에 {left, top}의 객체를 넣으면 파라미터가 한개 줄어드네요.
obj.path.set(extend({
left: objCenter.x,
top: objCenter.y
}, consts.fObjectOptions.SELECTION_STYLE));There was a problem hiding this comment.
네!! 이렇게 하니까 더 간결해졌네요. 감사합니다.
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* fix: free line position middle commit for prototype fix * fix: complate free line drawing bug * fix: added test and object extend method change * fix: apply code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
현상
버그 원인
path:created이벤트가 발생하면 obj를 받아서 origin을 (center, center)로 업데이트 해줌.버그 해결
Free Draw Path의 origin이 (left top -> center center) 로 업데이트 될때, path 객체의 x, y 포지션도 알맞게 업데이트 해줌.
http://10.78.9.21:8000/examples/example01-includeUi.html