collapse duplicated returns made by <br /> and block element fixed #57

nhn · Feb 5, 2020 · 9fac05d · 9fac05d
1 parent 357244b
commit 9fac05d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/libs/to-mark/src/renderer.basic.js b/libs/to-mark/src/renderer.basic.js
@@ -71,7 +71,7 @@ var basicRenderer = Renderer.factory({
     },
 
     //Paragraphs
-    'P': function(node, subContent) {
+    'P, DIV': function(node, subContent) {
         return subContent + '\n\n';
     },
     'LI P': function(node, subContent) {

diff --git a/libs/to-mark/src/toMark.js b/libs/to-mark/src/toMark.js
@@ -10,8 +10,8 @@ var DomRunner = require('./domRunner'),
     basicRenderer = require('./renderer.basic'),
     gfmRenderer = require('./renderer.gfm');
 
-var FIND_FIRST_LAST_RETURNS_RX = /^[\n]+|[\n]+$/g;
-
+var FIND_FIRST_LAST_RETURNS_RX = /^[\n]+|[\n]+$/g,
+    FIND_DUPLICATED_RETURNS_RX = /[ \xA0]+\n\n/g;
 /**
  * toMark
  * @exports toMark
@@ -72,6 +72,8 @@ function parse(runner, renderer) {
  * @return {string} result
  */
 function finalize(text) {
+    //collapse duplicated returns made by <br /> and block element
+    text = text.replace(FIND_DUPLICATED_RETURNS_RX, '\n');
     //remove first and last \n
     text = text.replace(FIND_FIRST_LAST_RETURNS_RX, '');
     return text;

diff --git a/libs/to-mark/test/toMark.spec.js b/libs/to-mark/test/toMark.spec.js
@@ -38,4 +38,10 @@ describe('toMark', function() {
 
         expect(toMark('<del>strike</del>')).toEqual('~~strike~~');
     });
+
+    it('collapse duplicated returns made by <br /> and block element', function() {
+        expect(toMark('<p>text<br />text<br /></p><p>text</p>')).toEqual('text  \ntext\n\ntext');
+        expect(toMark('<p>text<br />text  &nbsp;<br /></p><p>text</p>')).toEqual('text  \ntext\n\ntext');
+        expect(toMark('<p>text<br /></p><br /><p>text</p>')).toEqual('text\n\n  \ntext');
+    });
 });