fix: newline in table breaks syntax (close #16)(#17)

nhn · Feb 5, 2020 · 05afbcb · 05afbcb
1 parent 157fb1d
commit 05afbcb
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/libs/to-mark/src/renderer.gfm.js b/libs/to-mark/src/renderer.gfm.js
@@ -54,6 +54,8 @@ var gfmRenderer = Renderer.factory(basicRenderer, {
         return subContent;
     },
     'TR TD, TR TH': function(node, subContent) {
+        subContent = subContent.replace(/(\r\n)|(\r)|(\n)/g, '');
+
         return ' ' + subContent + ' |';
     },
     'TD BR, TH BR': function() {

diff --git a/libs/to-mark/test/renderer.gfm.spec.js b/libs/to-mark/test/renderer.gfm.spec.js
@@ -85,6 +85,11 @@ describe('gfmRenderer', function() {
                 expect(getMarkdownText('<table><tr><td></td></tr></table>', '', 4)).toEqual('  |');
                 expect(getMarkdownText('<table><tr><th></th></tr></table>', '', 4)).toEqual('  |');
             });
+
+            it('should replace newline', function() {
+                expect(getMarkdownText('<table><tr><td>te\nxt</td></tr></table>', 'text', 4)).toEqual(' text |');
+                expect(getMarkdownText('<table><tr><th>te\nxt</th></tr></table>', 'text', 4)).toEqual(' text |');
+            });
         });
 
         describe('TD BR, TH BR', function() {

diff --git a/libs/to-mark/test/tomark.gfm.spec.js b/libs/to-mark/test/tomark.gfm.spec.js
@@ -18,6 +18,20 @@ describe('toMark', function() {
             expect(toMark(htmlStr)).toEqual('| text |');
         });
 
+        it('single td containing newline', function() {
+            var htmlStr = [
+                '<table>',
+                '<tbody>',
+                '<tr>',
+                '<td>te\nxt</td>',
+                '</tr>',
+                '</tbody>',
+                '</table>'
+            ].join('');
+
+            expect(toMark(htmlStr)).toEqual('| text |');
+        });
+
         it('multiple td', function() {
             var htmlStr = [
                 '<table>',