fix: apply recurrenceRule changes (fix #936)
#976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lja1018
reviewed
Jan 5, 2022
| @@ -309,6 +309,10 @@ Base.prototype.updateSchedule = function(schedule, options) { | |||
| schedule.set('attendees', options.attendees); | |||
| } | |||
|
|
|||
| if (options.recurrenceRule) { | |||
There was a problem hiding this comment.
사실 그런걸 고려하기 시작하면 이 메서드는 싹 다 뜯어고쳐야해서 😢
그냥 기존에 다른 속성에 하던 방식과 동일한 방식으로 했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
recurrenceRulechanges in theupdateSchedulemethod.Thank you for your contribution to TOAST UI product. 🎉 😘 ✨