Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in getting-started.md #821

Merged
merged 1 commit into from
Jun 14, 2021
Merged

docs: fix typo in getting-started.md #821

merged 1 commit into from
Jun 14, 2021

Conversation

So-chiru
Copy link

@So-chiru So-chiru commented Jun 4, 2021

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Fixed key typo of header field to height, since IMonthOptions.grid? should implements header?: { height?: number }

height?: number;

@seonim-ryu
Copy link
Member

Can one of the admins verify this patch?

@adhrinae
Copy link
Contributor

@So-chiru Thanks for your contribution :) Will merge this.

@adhrinae adhrinae merged commit 5e78073 into nhn:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants