perf: variables.styl: remove unused Taskview prefixes #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jungeun-cho
reviewed
Jun 19, 2020
src/css/variables.styl
Outdated
| @@ -3,9 +3,6 @@ | |||
| css-prefix = 'tui-full-calendar-' | |||
| // Dayname | |||
| dayname = css-prefix + 'dayname-' | |||
| // Taskview | |||
| milestone = css-prefix + 'milestone-' | |||
| taskview = css-prefix + 'task-' | |||
| // Allday | |||
| allday = css-prefix + 'allday-' | |||
There was a problem hiding this comment.
It seems that the allday variable is also not used.
I think I can erase it, what do you think?
dilyanpalauzov
force-pushed
the
css_prefixes
branch
2 times, most recently
from
46512b1
to
446c1a4
Compare
dilyanpalauzov
changed the title
dilyanpalauzov
force-pushed
the
css_prefixes
branch
from
446c1a4
to
c79241a
Compare
jungeun-cho
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)