Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused Collection.merge() #619

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

dilyanpalauzov
Copy link

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

@seonim-ryu
Copy link
Member

Can one of the admins verify this patch?

Copy link
Contributor

@dongsik-yoo dongsik-yoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[06/01] I confirm that there is no occurrences of Collection.merge.

@jungeun-cho
Copy link
Contributor

ok to test

@jungeun-cho jungeun-cho merged commit d535ccd into nhn:master Jun 4, 2020
@dilyanpalauzov dilyanpalauzov deleted the collection_merge branch June 4, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants