Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: miscalculation when dragging event with hourStart option (fix #1228) #1229

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

adhrinae
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Fixed the position of the guide element when dragging event with the week.hourStart option.

Resolves #1228


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Member

@heenakwag heenakwag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다. 코드는 이견 없습니다.

e2e 테스트 추가하는 건 어떨까요? HourStartOption 스토리도 있으니까 page.goto(HourStartOptionURL);로 URL만 바꾸고 로직은 그대로 테스트 한벌 더 만들면 될 것 같아서요.

@adhrinae
Copy link
Contributor Author

@dotaitch
테스트 추가할까 하다가 작성하는데 생각보다 오래 걸릴수도 있겠다 싶어서 안했었어요. 그래도 말씀하신김에 간단한 형태로 추가해서 붙일게요.

Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@adhrinae adhrinae force-pushed the fix/event-moving-with-hour-start-option branch from dbed8a1 to ca9589c Compare July 27, 2022 09:31
Dohyung Ahn added 2 commits July 28, 2022 07:49
@adhrinae adhrinae force-pushed the fix/event-moving-with-hour-start-option branch from ca9589c to 087b6dd Compare July 27, 2022 22:51
@adhrinae adhrinae merged commit fc7ef8d into main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When hourStart is set, dragging events does not work correctly
3 participants