-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule.prototype.setAllDayPeriod logic #662
Labels
Comments
Thank you for raising an issue. Please make sure you have filled out issue respecting our form in English and given us as much context as possible. If not, the issue will be closed or not replied. |
jungeun-cho
added
Enhancement
Enhance performance or improve usability of original features.
To Do
labels
Jul 23, 2020
I understand. It needs to be improved. |
@jungeun-cho can I make a PR to fix it? |
Of course. |
lhysdl
added a commit
to lhysdl/tui.calendar
that referenced
this issue
Jul 23, 2020
lhysdl
added a commit
to lhysdl/tui.calendar
that referenced
this issue
Jul 23, 2020
lhysdl
added a commit
to lhysdl/tui.calendar
that referenced
this issue
Jul 23, 2020
jungeun-cho
added a commit
that referenced
this issue
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Summary
I don't understand why to use
if (util.isString(start)) { start = datetime.parse(start.substring(0, 10)); }
to deal with string arg as a special case, becausenew TZDate()
accept string arg.in my case, I store start-date value as json date, for example ''2020-07-06T16:00:00.000Z'' (my timezone is +8)
datetime.parse(start.substring(0, 10))
will give me 2020-07-06 as the start-date, which is not what I want.
new TZDate(start)
give me the right date which is 2020-07-07.As summary,
datetime.parse(start.substring(0, 10))
will not consider timezone likenew TZDate(start)
do, which lead to logical inconsistency.Version
1.12.13
The text was updated successfully, but these errors were encountered: