Unchecking isAllDay has no effect

[WilliamWsyHK]

Version

1.12.7

Development Environment

Windows IE 11 and Chrome 78

Current Behavior

Unchecking isAllDay has no effect. The beforeUpdateSchedule does not populate any changes when isAllDay is unchecked.

beforeUpdateSchedule: function (e) {
    let schedule = e.schedule;
    // here when nothing else changes except isAllDay, then changes === null.
    let changes = e.changes || {};
    console.log(changes.isAllDay);
    // should print "undefined".
}

Expected Behavior

isAllDay === false if the user has click to uncheck the all day checkbox.

[mariusa]

Set category = 'allday'
isAllDay is a read-only property

[WilliamWsyHK]

Maybe you mis-understood, but what I mean is not changing the isAllDay in my code, but when beforeUpdateSchedule is being called, value of isAllDay is not set. You can also experience the same in example app, especially unchecking the "All Day" checkbox.

[mariusa]

I recommend to use category == 'allday' to check. Simpler than having N properties isThis, isThat, isScheduleStartingAt8AM...

[WilliamWsyHK]

Thanks @mariusa, but that will definitely defeat the purpose of having isAllDay from the start, i.e. why the team create such property if you are not intentionally change its value when there is updates on the field? This is just confusing.

But for now it make sense to use category === 'allday' to check, provided that the update will populate the changed value.

[mariusa]

Right. There is a proposal to remove 'isAllDay'

…

On Tue, Nov 26, 2019, 16:25 WilliamWsyHK ***@***.***> wrote: Thanks @mariusa <https://github.com/mariusa>, but that will definitely defeat the purpose of having isAllDay from the start, i.e. why the team create such property if you are not intentionally change its value when there is updates on the field? This is just confusing. But for now it make sense to use category === 'allday' to check, provided that the update will populate the changed value. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#463?email_source=notifications&email_token=AAJZOASJZG4BJQD4BVYJTZLQVUWURA5CNFSM4JNKZ672YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFGFYVI#issuecomment-558652501>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJZOAUDX4YUSL2USSXSHFTQVUWURANCNFSM4JNKZ67Q> .

[jungeun-cho]

@WilliamWsyHK
I reproduced it.
If you changed the All Day checkbox
It is correct to send isAllDay or category information in changes.

I'll fix it in the next patch version.