This repository was archived by the owner on Oct 24, 2019. It is now read-only.
feat: add type definition #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohee-lee7
reviewed
Mar 25, 2019
| { | ||
| "name": "@toast-ui/vue-grid", | ||
| "version": "1.0.4", | ||
| "version": "1.0.5", |
Contributor
There was a problem hiding this comment.
package-lock.js의 version도 함께 바껴야할 것 같습니다.
Author
There was a problem hiding this comment.
이거 반영하긴 했는데..
생각해보니 package-lock.json 버전은 매번 업데이트 하면 안되겠네요.
이 파일은 직접 관리하는 파일이 아니라 자동 생성되는 파일이라서 수동으로 수정하면 안될 것 같아요.
이 패키지의 버전이 올라가도 디펜던시가 추가되거나 업데이트 된 게 아니라면 그대로 유지하는 게 맞는 것 같습니다.
Contributor
|
리뷰 완료입니다.!!! Typescript 어렵네요.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description