Wrong merge request changes.

[Indomitable]

Hi,
First I want to say this is good idea which can be very useful.
One thing that I found is that in the "Merge Request's Changes" diff is generated between the base commit and HEAD, but it should be between target branch and HEAD.
The command git diff target-branch...merge-request-branch gives exactly what we need.

The problem is visible if there is a long running MR with updates from target branch, then in changes we show changes which actually were done in target branch.

[nhat-phan]

Thank you for your feedback.

Unfortunately, I can't guarantee that the plugin works 100% automatically in all cases. Depending on the git process and situation, the plugin requires some manual work from developers. For example, you have to update/pull the target branch manually if the target branch was rebased before clicking "Code Review".

I'll add a new feature that automatically fetches and pulls the target branch before displaying changes. Also in case there are any problems, the feature will show a message displaying tasks that have to be done manually.

Hope it helps.

[XIII-th]

@nhat-phan it's important feature for big teams. When I get a merge request, the diff view doesn't take me enough information about changes because it out of date. File can be changed a lot at the moment and target branch's HEAD moved forward.
Because of it, I unable to use this wonderful plugin in most cases (

[bojanbg]

Both my target branch and source branch are up to date locally, yet I still see changes that don't appear in the GitLab web view.