nanosecond DateTime reader bugfix

connamara#591
nhamed · Mar 30, 2020 · ba9d901 · ba9d901
1 parent c07dd51
commit ba9d901
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/QuickFIXn/Fields/Converters/DateTimeConverter.cs b/QuickFIXn/Fields/Converters/DateTimeConverter.cs
@@ -112,7 +112,7 @@ public static System.DateTime ConvertToDateTime(string str, TimeStampPrecision p
             try
             {
                 //Avoid NanoString Path parsing if not possible from string length
-                if (str.Length > DATE_TIME_MAXLENGTH_WITHOUT_NANOSECONDS && precision == TimeStampPrecision.Nanosecond)
+                if (str.Length > DATE_TIME_MAXLENGTH_WITHOUT_NANOSECONDS)
                 {
                     return DateTimeFromNanoString(str);
                 }

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -21,6 +21,7 @@ What's New
 * (patch) #383/#582 - Fix debug logfile name clash (chizz5056/gbirchmeier)
 * (patch) #410/#583 - SocketAcceptPort now fully-obeyed (mvdtom)
 * (minor) #585/#323 - Add Message.ToXML() (baffles/gbirchmeier)
+* (patch) #591 - Nanosecond DateTime reader bugfix (gbirchmeier)
 
 ### v1.9.0:
 * (minor) #469 - Add support for NET Standard 2.0 (jhickson)

diff --git a/UnitTests/FieldMapTests.cs b/UnitTests/FieldMapTests.cs
@@ -99,6 +99,16 @@ public void DateTimeFieldTest()
             Assert.AreSame(r, tt);
         }
 
+        [Test]
+        public void DateTimeFieldNanoTest()
+        {
+            fieldmap.SetField(new StringField(Tags.TransactTime, "20200309-20:53:10.643649215"));
+            TransactTime tt = new TransactTime();
+            fieldmap.GetField(tt);
+            // Ticks resolution is 100 nanoseconds, so we lose the last 2 decimal points
+            Assert.That(tt.Obj.Ticks, Is.EqualTo(637193839906436492));
+        }
+
         [Test]
         public void DateOnlyFieldTest()
         {