use SslProtocol.None instead of deprec'd .Default

nhamed · Jun 16, 2020 · 4957f3c · 4957f3c
1 parent 1943504
commit 4957f3c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/QuickFIXn/SocketSettings.cs b/QuickFIXn/SocketSettings.cs
@@ -145,7 +145,7 @@ public class SocketSettings : ICloneable
         public SocketSettings()
         {
             ValidateCertificates = true;
-            SslProtocol = SslProtocols.Default;
+            SslProtocol = SslProtocols.None;
             CheckCertificateRevocation = true;
             RequireClientCertificate = true;
             SocketNodelay = true;

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -31,6 +31,7 @@ What's New
 * (patch) #564 - NuGet package creation! (fourpastmidnight)
 * (patch) #612 - add Serilog standalone example (pavka1799)
 * (patch) #602 - Correct DD.CheckValue() to be compatible with AllowUnknownMessageFields (roblugt/gbirchmeier)
+* (patch) none - use SslProtocol.None instead of deprecated .Default (gbirchmeier)
 
 ### v1.9.0:
 * (minor) #469 - Add support for NET Standard 2.0 (jhickson)

diff --git a/UnitTests/SocketSettingsTest.cs b/UnitTests/SocketSettingsTest.cs
@@ -21,7 +21,7 @@ public void DefaultValues()
             Assert.IsTrue(socketSettings.ValidateCertificates);
             Assert.IsNull(socketSettings.CertificatePath);
             Assert.IsNull(socketSettings.CertificatePassword);
-            Assert.AreEqual(SslProtocols.Default,socketSettings.SslProtocol);
+            Assert.AreEqual(SslProtocols.None, socketSettings.SslProtocol);
             Assert.IsTrue(socketSettings.CheckCertificateRevocation);
             Assert.IsFalse(socketSettings.UseSSL);
             Assert.IsNull(socketSettings.CACertificatePath);