Improve non-standard type encoding #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the JSON encoding of non-standard types by introducing and using the
.defaultsmodule. The.defaultsmodule adds helper functions that can test and apply formatting for types not supported by a given encoder.Please note that in doing so, some outputs of the
JsonFormatterhave changed. That said these changes return more "reasonable" results rather the the originalstr(o)fallback.For more detailed list of changes to the encoders see the CHANGELOG.
Test Plan
Have added additional tests and now check for specific output.