New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return a hot observable from getTranslation #312

Closed

imgx64 wants to merge 2 commits into ngx-translate:master from imgx64:patch-2

Contributor

imgx64 commented Nov 6, 2016

Fixes #308


          Don't return a hot observable from getTranslation

3599e8e

Fixes #308

imgx64 mentioned this pull request

Fix TranslateService.get when called while pending #311

Closed


          Unset TranslateService.pending earlier

6b81ccf

Contributor Author

imgx64 commented Nov 20, 2016

Don't merge this, #329 fixes this without removing share().

imgx64 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet