Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TranslateStore #857

Closed
hspier opened this issue May 22, 2018 · 2 comments
Closed

Export TranslateStore #857

hspier opened this issue May 22, 2018 · 2 comments

Comments

@hspier
Copy link
Contributor

hspier commented May 22, 2018

Current behavior

TranslateStore is exported as a private Angular symbol (ɵa) but there are situations where it is needed to be accessed when implementing a TranslateLoader for example.

Expected behavior

TranslateStore is exported publicly.

What is the motivation / use case for changing the behavior?

There are certain use cases where the store needs to be accessible. One such example is an application that has a common bundle that is loaded at startup and has another bundle specific per area of the app. The specific bundle is lazily loaded. When changing locale, both bundles needs to be refreshed and this can be accomplished when accessing the store (since the translate service might or might not be the root service).

How do you think that we should implement this?

This is a rather straightforward ask and should be easy to implement.

@ocombe
Copy link
Member

ocombe commented May 22, 2018

True, would mind making a PR for that?

@hspier
Copy link
Contributor Author

hspier commented May 22, 2018

@ocombe Sure will create it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants