Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First time joining announcement #64

Open
EmanYm opened this issue Jun 2, 2017 · 8 comments
Open

First time joining announcement #64

EmanYm opened this issue Jun 2, 2017 · 8 comments

Comments

@EmanYm
Copy link

EmanYm commented Jun 2, 2017

Nucleus has a "first time joined" announcement option. Is there a chance that message can be sent to discord through this plugin?

@ResqDiver1317
Copy link

if possible +1 for this. Our community has 4 servers right now all lined via the bridge and currently, only our Spigot based server announces new players through the discord link. It would be nice if our 2 1.10.2 sponge and our 1.12.2 sponge servers also did the same via DiscordBridge. We like to welcome new members as they join our community so it would be nice to see they are new no matter which server they connect to.

@Mohron
Copy link
Contributor

Mohron commented Nov 20, 2017

@ResqDiver1317 do you currently have a Sponge plugin capable of identifying new network players? Nucleus has the ability to identify new players on a specific server but it does not have any built-in capabilities for tracking across multiple servers. Supporting nucleus' first join message would be easy and would fit in well. Adding the capability to track who's new across many servers on the other hand is out of the scope of this plugin.

@ResqDiver1317
Copy link

All 3 of our Sponge servers are running Nucleus so if it could hook to that as the OP referenced, that would do it for us. I understand it would cause it to announce community wide with a new player message when someone who has been on 1 of our servers joined a different one of our servers but that would be preferable to no new player announcement at all. We are getting several new players joining directly to our modded servers so it would nice to see the announcement across the community, even if it would cause so to speak "false" new player announcements just because they changed from one server to a different one.

@Mohron
Copy link
Contributor

Mohron commented Nov 20, 2017

I have no issues implementing this feature in my fork via a nucleus integration. When I'm done I'll send a PR to Kai so it will hopefully be included in the next official release.

@Mohron
Copy link
Contributor

Mohron commented Nov 21, 2017

screenshot_20171121-112219

Mohron added a commit to DevOnTheRocks/DiscordBridge that referenced this issue Nov 21, 2017
@ResqDiver1317
Copy link

That looks very promising! Thank you for work Mohron!

@EmanYm
Copy link
Author

EmanYm commented Nov 22, 2017

Wait, you continued a fork of Discord Bridge?
goes to rummage through your PRs like a raccoon through the trash at Clucking Bell on taco Tuesday

@Mohron
Copy link
Contributor

Mohron commented Nov 22, 2017

I've been a long time contributor so of course I have a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants