Remove nghttp3_settings.initial_ts

[tatsuhiro-t]

Because the token is still full until the first anomaly is detected, the initial value of timestamp can be 0, that eliminates the need for initial_ts.

[gemini-code-assist]

Summary of Changes

Hello @tatsuhiro-t, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the nghttp3_settings configuration by eliminating the initial_ts field. The rationale is that the initial timestamp for the glitch rate limiter can safely default to zero, as the token bucket is inherently full until an anomaly is first detected. This change reduces API surface area and internal complexity, ensuring that the system behaves correctly without requiring an explicit initial timestamp setting.

Highlights

• Removal of initial_ts field: The nghttp3_settings.initial_ts field has been removed from the nghttp3_settings structure, simplifying the configuration.
• Simplified Glitch Rate Limiter Initialization: The glitch rate limiter now initializes with a timestamp of 0, as the token bucket is considered full until the first anomaly is detected, eliminating the need for an explicit initial timestamp.
• Documentation and Test Updates: Corresponding documentation, fuzzer configurations, and test cases have been updated to reflect the removal of initial_ts and its associated logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the nghttp3_settings.initial_ts field, simplifying the API by hardcoding the initial timestamp for the glitch rate limiter to 0. This is a good simplification, as the initial_ts field is no longer necessary. The changes are consistently applied across the public API, internal implementation, documentation, and tests. The logic for enabling and disabling the glitch rate limiter remains correct. The code quality is high and I have no further suggestions.