Use __FILE_NAME__ instead of __FILE__ #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use __FILE_NAME__ instead of __FILE__ not to include a full source file path.
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Nov 3, 2023
Having this in `_build.sh` isn't correct because it leaves the project subdir included in `__FILE__` values, while in autotools builds this is missing, creating a slight difference in binaries built with cmake vs autotools. Also, these now received a fix in both ngtcp2 and nghttp3, and we now have detection in place for this issue. BoringSSL also had a local fix that I missed in the previous commits. Make this setting pre-project again. Follow-up to efef82c Follow-up to c29fb63 Refs: ngtcp2/ngtcp2#1003 ngtcp2/ngtcp2#1006 ngtcp2/ngtcp2@2822c7f ngtcp2/nghttp3#176 ngtcp2/nghttp3@71bf1ef
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Nov 3, 2023
Having this in `_build.sh` isn't correct because it leaves the project subdir included in `__FILE__` values, while in autotools builds this is missing, creating a slight difference in binaries built with cmake vs autotools. Also, these now received a fix in both ngtcp2 and nghttp3, and we now have detection in place for this issue. BoringSSL also had a local fix that I missed in the previous commits. Previous patch also left `CFLAGS` uninitialized in `libressl-cmake.sh`. Make this setting pre-project again. Follow-up to c29fb63 Refs: ngtcp2/ngtcp2#1003 ngtcp2/ngtcp2#1006 ngtcp2/ngtcp2@2822c7f ngtcp2/nghttp3#176 ngtcp2/nghttp3@71bf1ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FILE_NAME instead of FILE not to include a full source file path.