Skip to content

Enable AVX2 on Clang (GCC Frontend) builds in Windows #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hmartinez82
Copy link

No description provided.

@hmartinez82 hmartinez82 changed the title Enable AVX on Clang builds in Windows Enable AVX on Clang (GCC Frontend) builds in Windows Apr 20, 2025
@azonenberg
Copy link
Collaborator

Can we get @bvernoux or any other Windows users/devs to weigh in on this? I see nothing wrong with the patch from a code style/quality perspective, it's a trivial one-line edit, but don't actively use ngscopeclient on Windows so can't easily test if it breaks things.

@azonenberg azonenberg added help wanted Extra attention is needed build Build / CI toolchain labels Apr 23, 2025
@bvernoux
Copy link
Contributor

bvernoux commented Apr 23, 2025

All seems fine but I have not tested Clang version
The modification is small anyway with "&& !defined(clang)" to avoid removing AVX on Clang

@azonenberg
Copy link
Collaborator

Yes, the modification is trivial. But we need someone to actually thoroughly stress test a clang-compiled ngscopeclient on windows to verify that it doesn't hit any edge cases and crash due to AVX issues.

@hmartinez82 hmartinez82 changed the title Enable AVX on Clang (GCC Frontend) builds in Windows Enable AVX2 on Clang (GCC Frontend) builds in Windows Apr 23, 2025
@bvernoux
Copy link
Contributor

So far I have no way to Build and Test it with Clang on Windows X86_64 (My setup is only to build with MingW64 with GCC and I do not have really the time to configure all for Clang, I'm not even sure there is any interest to keep Clang as that requires to test on different Toolchain which is quite time consuming especially with all feature present in ngscopeclient ...) maybe we can merge it and test on the automatic build and ask to other guys with Windows X86/X64 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build / CI toolchain help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants