Skip to content

trigger + buffer flush #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@

*.bak
1 change: 1 addition & 0 deletions scopehal/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ set(SCOPEHAL_SOURCES
RohdeSchwarzHMC804xPowerSupply.cpp
RidenPowerSupply.cpp
KuaiquPowerSupply.cpp
WattWaveX4.cpp

StandardColors.cpp
Filter.cpp
Expand Down
11 changes: 11 additions & 0 deletions scopehal/SCPIUARTTransport.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -171,3 +171,14 @@ bool SCPIUARTTransport::IsCommandBatchingSupported()
{
return false;
}

void SCPIUARTTransport::FlushRXBuffer()
{
if (!IsConnected())
return;
unsigned char buf[1024];
//ibclr(m_handle);
while (ReadRawData(1024, buf) != 0) {}
//do nothing
return;
}
2 changes: 1 addition & 1 deletion scopehal/SCPIUARTTransport.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class SCPIUARTTransport : public SCPITransport
virtual std::string ReadReply(bool endOnSemicolon = true, std::function<void(float)> progress = nullptr) override;
virtual size_t ReadRawData(size_t len, unsigned char* buf, std::function<void(float)> progress = nullptr) override;
virtual void SendRawData(size_t len, const unsigned char* buf) override;

virtual void FlushRXBuffer(void) override;
virtual bool IsCommandBatchingSupported() override;
virtual bool IsConnected() override;

Expand Down
1 change: 1 addition & 0 deletions scopehal/Trigger.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Trigger::Trigger(Oscilloscope* scope)
, m_level(m_parameters["Lower Level"])
{
m_level = FilterParameter(FilterParameter::TYPE_FLOAT, Unit(Unit::UNIT_VOLTS));
m_level.MarkHidden();
}

Trigger::~Trigger()
Expand Down
Loading