Does not compile due to issues with HID

[whitequark]

For the last few days the builds have been failing with:

/home/whitequark/Projects/scopehal-apps/lib/scopehal/SCPIHIDTransport.cpp: In static member function ‘static std::vector<TransportEndpoint> SCPIHIDTransport::EnumTransportEndpoints()’:
/home/whitequark/Projects/scopehal-apps/lib/scopehal/SCPIHIDTransport.cpp:171:29: error: ‘EnumerateDevices’ is not a member of ‘HID’
  171 |         auto devices = HID::EnumerateDevices();
      |                             ^~~~~~~~~~~~~~~~

I have not investigated why, but I think all of the submodules are up to date at least.

[azonenberg]

This was added in ngscopeclient/xptools@2221336 so maybe when you updated to latest scopehal it didn't update the xptools submodule pointer?

[whitequark]

Hm, probably. What do you think about adding some CMake machinery to definitively check if the submodules are up-to-date and reporting it if not?

[azonenberg]

I'm all for that. Submodules in general are a huge pain but when you have dependencies that aren't set up for separate packaging there's not a whole lot of good options...

Let me know if a manual update fixes it, if so we can close this issue then file a separate one for detection of stale submodules?

[whitequark]

Yep, it was a missing submodule update--not sure how, given I examined my bash history and here are the lines showing I did run git submodule update -r:

70227  z ngscopeclient
70228  git pull
70229  ls
70230  make
70231  git submodule update 
70232  make
70233  git submodule update 
70234  git pull
70235  git submodule update 
70236  git submodule update  -r
70237  git pull
70238  make