docs(signals): correct entityMap signal formatting in documentation#5096
Merged
timdeschryver merged 2 commits intongrx:mainfrom Feb 18, 2026
Merged
docs(signals): correct entityMap signal formatting in documentation#5096timdeschryver merged 2 commits intongrx:mainfrom
timdeschryver merged 2 commits intongrx:mainfrom
Conversation
…entation Fix formatting issue in entity-management.md for entityMap signal.
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ngrx-site-v21 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| - `ids: Signal<EntityId[]>`: An array of all entity IDs. | ||
| - `entityMap: Signal<EntityMap<Todo>>`: A map of entities where each key is an ID. | ||
| - `entityMap: Signal<EntityMap<Todo>`: A map of entities where each key is an ID. |
Member
There was a problem hiding this comment.
the current version is correct - we need two closing angle brackets, one for the EntityMap generic argument, another one for the Signal generic argument
Contributor
Author
There was a problem hiding this comment.
take a look to the presentation there's something wrong in the renderer
Member
There was a problem hiding this comment.
I see. If you want to update the PR, I think that replacing angle brackets with < and > will fix the issue
Contributor
Author
There was a problem hiding this comment.
Okay I will do it, I will update it.
Member
Use HTML entities so generic types (e.g. Signal<EntityId[]>) render correctly.
markostanimirovic
changed the title
markostanimirovic
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…entation
Fix formatting issue in entity-management.md for entityMap signal.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I was reading the docs and noticed that the
>is duplicated. When I checked the GitHub repo, I found that it’s just a typo. However, I also observed that the generic type isn’t shown in the docs—only the base type is, for exampleSignal<Todo[]>is shown as justSignal.