test(example-app-e2e): migrate e2e tests from Cypress to Playwright#5084
Open
wotan-allfather wants to merge 1 commit intongrx:mainfrom
Open
test(example-app-e2e): migrate e2e tests from Cypress to Playwright#5084wotan-allfather wants to merge 1 commit intongrx:mainfrom
wotan-allfather wants to merge 1 commit intongrx:mainfrom
Conversation
Closes ngrx#5083 - Remove Cypress config, support files, and dependencies - Add Playwright config with Nx preset and webServer configuration - Convert round-trip.cy.ts to round-trip.spec.ts using Playwright API - Update project.json to use @nx/playwright:playwright executor - Update tsconfig.json for Playwright compatibility - Add @nx/playwright and @playwright/test dependencies Test coverage: - Login flow - Book search functionality - Add/remove books from collection - View collection - Sign out Note: Invalid credentials test is skipped pending investigation of Angular Material error message visibility in Playwright.
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
timdeschryver
requested changes
Feb 6, 2026
Member
timdeschryver
left a comment
timdeschryver
left a comment
There was a problem hiding this comment.
Thanks for the PR @wotan-allfather
Could you please look the failing build.
It seems as if the example-app is broken, so the e2e tests will fail.
To resolve this remove the strictActionWithinNgZone at strictActionWithinNgZone.
I think with this change, that the timeouts in the test cases and the skipped test should also be resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5083
Test coverage:
Note: Invalid credentials test is skipped pending investigation of Angular Material error message visibility in Playwright.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information