feat(signals): add ability to provide SignalStore at the platform level#4964
Merged
timdeschryver merged 3 commits intongrx:mainfrom Oct 13, 2025
Merged
feat(signals): add ability to provide SignalStore at the platform level#4964timdeschryver merged 3 commits intongrx:mainfrom
timdeschryver merged 3 commits intongrx:mainfrom
Conversation
✅ Deploy Preview for ngrx-site-v19 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
markostanimirovic
requested changes
Oct 4, 2025
d4ee15f to
40110c4
Compare
Injectable (#4963)
markostanimirovic
approved these changes
Oct 12, 2025
timdeschryver
approved these changes
Oct 13, 2025
Member
|
Thanks @MillerSvt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Cannot pass any
providedInexceptroot.Closes #4963
What is the new behavior?
Added support to any not deprecated
providedIntypes.Does this PR introduce a breaking change?
Other information
I was thinking of just adding the
platformto the union. But it seems that if here we just pass the value into theInjectabledecorator, then we should rely on the typing of this decorator. The only thing seems to be that we should exclude deprecated types from union, so as not to add support for what will be removed soon.