Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Store): Allow parent modules to provide reducers with tokens #36

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

MikeRyanDev
Copy link
Member

Also allows feature modules to declare just one reducer function instead
of a complete action reducer map.

cc @vsavkin

Closes #34

Also allows feature modules to declare just one reducer function instead
of a complete action reducer map.

Closes #34
@brandonroberts brandonroberts merged commit 069b12f into master Jun 12, 2017
@brandonroberts brandonroberts deleted the feat/store-tokens branch June 12, 2017 00:50
@bbaia
Copy link
Contributor

bbaia commented Jun 30, 2017

Also allows feature modules to declare just one reducer function instead
of a complete action reducer map.

Why only feature modules ? why not root module too ?
If not, you should throw an error or make TypeScript fails if you provide a reducer function to the forRoot method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants