Skip to content

docs(store): add missing types to walkthrough example #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brandonroberts merged 3 commits into from
Oct 26, 2021
Merged

docs(store): add missing types to walkthrough example #3206

brandonroberts merged 3 commits into from
Oct 26, 2021

Conversation

@muhammadawaisshaikh
Copy link
Contributor

@muhammadawaisshaikh muhammadawaisshaikh commented Oct 26, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

Closes #3203

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@muhammadawaisshaikh muhammadawaisshaikh mentioned this pull request Oct 26, 2021
Closed
@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 26, 2021 •
edited
Loading

Preview docs changes for dcb3b78 at https://previews.ngrx.io/pr3206-dcb3b780/

muhammadawaisshaikh and others added 2 commits October 26, 2021 16:29
@muhammadawaisshaikh @markostanimirovic
Update projects/ngrx.io/content/examples/store-walkthrough/src/app/bo…
bb8cdf4 
…ok-collection/book-collection.component.ts

Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
@muhammadawaisshaikh @markostanimirovic
Update projects/ngrx.io/content/examples/store-walkthrough/src/app/bo…
dcb3b78 
…ok-list/book-list.component.ts

Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
muhammadawaisshaikh
muhammadawaisshaikh commented Oct 26, 2021
View reviewed changes
Copy link
Contributor Author

@muhammadawaisshaikh muhammadawaisshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes accepted as per Marko.

@markostanimirovic markostanimirovic changed the title docs(store): Add Missing Types to the Store Walkthrough Section (#3203) docs(store): add missing types to walkthrough example (#3203) Oct 26, 2021
@markostanimirovic markostanimirovic changed the title docs(store): add missing types to walkthrough example (#3203) docs(store): add missing types to walkthrough example Oct 26, 2021
@brandonroberts brandonroberts merged commit 9b65db3 into ngrx:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@markostanimirovic markostanimirovic markostanimirovic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Missing Types to the Store Walkthrough Section

4 participants

@muhammadawaisshaikh @ngrxbot @brandonroberts @markostanimirovic