Skip to content

Conversation

@LayZeeDK
Copy link
Contributor

@LayZeeDK LayZeeDK commented Apr 19, 2021

Despite its name, a ComponentStore is not necessarily tied to the lifecycle of a component. Let the description of ComponentStore#effect reflect this.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The description of ComponentStore#effect states that an effect is tied to the lifecycle of a component.

What is the new behavior?

The description of ComponentStore#effect states that an effect is tied to the lifecycle of the component store.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Despite it's name, a ComponentStore is not necessarily tied to the lifecycle of a component. Let the description of `ComponentStore#effect` reflect this.
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 19, 2021

Preview docs changes for d96c176 at https://previews.ngrx.io/pr2997-d96c1765/

@brandonroberts brandonroberts merged commit 53f3879 into ngrx:master Apr 19, 2021
@LayZeeDK LayZeeDK deleted the patch-1 branch April 20, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants