Skip to content

Conversation

bhalash
Copy link
Contributor

@bhalash bhalash commented Jul 11, 2019

These were missing from modules/store/src/index.ts.

Closes #2007

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

@ngrx/store does not export the StoreConfig and RootStoreConfig interfaces from modules/store/src.index.ts, which it should per the NgRx guide.

Closes #2007

What is the new behavior?

@ngrx/store now exports the StoreConfig and RootStoreConfig modules per Using Dependency Injection -> Injecting Feature Config

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@brandonroberts
Copy link
Member

@bhalash will you amend the commit and do a force push so CI will pick it up? Thanks

These were missing from `modules/store/src/index.ts`.

Closes #2007
@bhalash
Copy link
Contributor Author

bhalash commented Jul 13, 2019

@brandonroberts Done!

@brandonroberts brandonroberts merged commit 5e01e50 into ngrx:master Jul 13, 2019
@brandonroberts
Copy link
Member

Thanks @bhalash!

jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/store: StoreConfig interface missing from exports.
3 participants