Use ngDevMode instead of isDevMode() to facilitate tree-shaking

[amakhrov]

Which @ngrx/* package(s) are relevant/related to the feature request?

component-store, entity, router-store, store

Information

The packages have a bunch of run-time warnings, guarded by Angular's isDevMode() check. While this guard suppresses respective warnings at run time, the related code is still included in the generated bundles.

Angular's own approach for this is using the global ngDevMode constant, that is replaced with a concrete value at compile time (by webpack), and allows to eliminate the dev code from the resulting prod bundle.

It would be nice to have the same optimization for NgRx.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

• Yes
• No

[david-shortman]

I'd be willing to submit a PR. Nice catch!

[fmalcher]

Since the environment files will not be generated by default anymore (see angular/angular-cli#23931), will the isDevMode() function be the new way to configure the store devtools?

StoreDevtoolsModule.instrument({ maxAge: 25, logOnly: !isDevMode() })

[alan-agius4]

Couple of small observations.

• ngDevMode is a private API that is not intended to be used outside of the @angular/ packages. The meaning of this can change without warning.
• It is expected that the isDevMode() does not cause dead-code to be eliminated, this is because optimizers such as terser and esbuild are unable to statically analyse it's value.

There is some discussion around this in angular/angular-cli#23738

[brandonroberts]

Closing as wontfix for now