Skip to content

ChangeItemSetFactory Update does not allow entities with Number IDs #1988

Closed
@allout58

Description

Minimal reproduction of the bug/regression with instructions:

https://stackblitz.com/edit/ngrx-seed-data-update-bug

See the type error in the example() function, compared with an entity with a String ID

Expected behavior:

ChangeSetItemFactory.update should allow for updating entities with a Number type ID

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

NgRx: 8.0.1
Angular: 8.0.2
Node: 10.15.3

Other information:

Although they type Update<T> allows for UpdateStr<T> | UpdateNum<T>, the update function forces T to extend {id: string} only

I would be willing to submit a PR to fix this issue

[X] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions