-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New models, Google Gemini, some adjustements #25
base: main
Are you sure you want to change the base?
Conversation
Are you we okey ? |
Hello, I think I will need to update the readme (beyond what is proposed in the PR) to make it more clear now that there are many model options. I can take a look this weekend. |
Okey, |
I'm reading through your PR and I noticed there might be an issue in the last set of changes. In the code for the mistral API, it looks like you are using the OpenAI tokenizers: https://github.com/ngruver/llmtime/blob/main/models/mistral_api.py#L33. Did you confirm that this makes? It probably makes more sense to use the huggingface mistral tokenizers, unless it is known that their API models use a different tokenizer. |
Other issues/comments:
|
Hello, |
Also for Mistral tokenizer ok |
In this update,
Please note that the NLL calculation is not yet implemented for google, also for the past mistral model.