Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forwarding API #120

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Update forwarding API #120

merged 1 commit into from
Sep 26, 2023

Conversation

CarlAmko
Copy link
Contributor

@CarlAmko CarlAmko commented Sep 14, 2023

Resolves https://github.com/ngrok-private/ngrok/issues/21878

HTTP lite example
image
image

Forward lite example
image
image
image

Copy link
Collaborator

@jrobsonchase jrobsonchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! A few minor notes, and we'll need to support proxy proto/header rewriting at some point, but it's as good of a start as we've got in Rust 👍

session.go Show resolved Hide resolved
session.go Outdated Show resolved Hide resolved
session.go Outdated Show resolved Hide resolved
session.go Outdated Show resolved Hide resolved
@CarlAmko CarlAmko marked this pull request as ready for review September 26, 2023 13:49
@CarlAmko CarlAmko merged commit ac50937 into main Sep 26, 2023
2 checks passed
@CarlAmko CarlAmko deleted the carl/connection-forwarding branch September 26, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants