-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(refactor): refactored user schema to camelcasing #53
chore(refactor): refactored user schema to camelcasing #53
Conversation
WalkthroughThe recent updates across various JavaScript files and Mongoose schemas in the codebase reflect a shift towards standardizing naming conventions. Specifically, the changes involve adopting camelCase for variable and property names, aligning with common JavaScript practices. This includes modifying fields such as Changes
Assessment against linked issues
Poem
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @prasanth7890, thank you for raising a pull request.
Currently, the pull request is marked as https://github.com/MilanCommunity/Milan-Backend/labels/%F0%9F%9F%A3%20status%3A%20todo so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this pull request is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (6)
- routes/club/Club.js (1 hunks)
- routes/display/Display.js (1 hunks)
- routes/user/Auth.js (3 hunks)
- routes/user/User.js (3 hunks)
- schema/user/ReportProblemSchema.js (1 hunks)
- schema/user/UserSchema.js (1 hunks)
Files skipped from review due to trivial changes (3)
- routes/club/Club.js
- routes/display/Display.js
- routes/user/Auth.js
Additional comments: 4
routes/user/User.js (1)
- 103-103: The query field has been correctly updated to
userType: "individual"
to match the new camelCase naming convention.schema/user/ReportProblemSchema.js (2)
5-20: The changes to the
ReportProblemSchema
fields to use camelCase are consistent with the pull request's intent to standardize naming conventions and align with JavaScript best practices.3-20: Verify that all references to the modified schema fields in the codebase have been updated to the new camelCase names to maintain consistency and prevent potential errors.
schema/user/UserSchema.js (1)
- 3-14: The changes to the
UserSchema
fields fromusertype
touserType
,firstname
tofirstName
, andlastname
tolastName
are correctly implemented and follow JavaScript naming conventions.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- routes/user/User.js (3 hunks)
Additional comments: 2
routes/user/User.js (2)
37-42: The changes to the
UserData
object correctly reflect the new camelCase naming convention.102-104: The query condition has been correctly updated to use camelCase for
userType
.
closes #44
👷🏻 Changes made
I rewrote the UserSchema and ReportProblemSchema to follow camelCase naming conventions for improved readability and consistency. Also updated instances in code where these schema models are referenced to reflect the case changes.
Summary by CodeRabbit
Refactor
usertype
touserType
,firstname
tofirstName
,lastname
tolastName
,reportmessage
toreportMessage
).Bug Fixes
Documentation