Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FIX] web: prevent traceback in edit mode with embedded video
Since [this other commit], initializing the color picker could trigger a traceback. The traceback was due to the fact that for users to be able to drag/move the color picker as they wished across different frames, we needed access to the document of all the frames on the page. Unfortunately, if one of these frames was not of the same origin, a traceback was displayed. This commit corrects how we collect documents from frames on the page, by only taking those whose document we have the right to see (which do not raise a cross origin error). I didn't succeed to reproduce the bug locally, but I got it on the runbot with theme Nursery / Kiddo by dropping the block banner on the page, the error appears because the block contains a vimeo video. In fact, you just need to have embedded content (youtube / vimeo / ... video for example) start edit mode, click on the block containing the video and the error is displayed. [this other commit]: odoo@63bf363 runbot-22573 closes odoo#126240 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
- Loading branch information