refactor: always use native intersection observer #159
Conversation
|
|
| // we fall back to the native implementation. Accessing the native implementation | ||
| // allows us to remove `runOutsideAngular` calls and reduce indentation, | ||
| // making the code a bit more readable. | ||
| export const IntersectionObserver: typeof globalThis.IntersectionObserver = |
There was a problem hiding this comment.
but what about applications that uses zone and need to run it outside the zone?
There was a problem hiding this comment.
That would get the first operand immediately (globalThis.__zone_symbol__IntersectionObserver).
There was a problem hiding this comment.
I meant that you removed the run outside zone call from the code
There was a problem hiding this comment.
Yeah it's not required. It's always running the native implementation (which is not intercepted by Angular).
- when zone.js is included it gets
__zone_symbol__IntersectionObserver - when zoneless is enabled it gets
|| .IntersectionObserver
There was a problem hiding this comment.
But with zone js enabled this will run inside the zone
There was a problem hiding this comment.
It will. But the emission from the observable (inView()) would be outside of the zone. Native implementation is always running outside of the zone.
There was a problem hiding this comment.
But the emission from the observable (inView()) would be outside of the zone
even if we use zone js?
In this commit, we retrieve the native `IntersectionObserver` implementation hidden by `__zone_symbol__IntersectionObserver`. This would be the unpatched version of the observer present in zone.js environments. Otherwise, if the user is using zoneless change detection (and zone.js is not included), we fall back to the native implementation. Accessing the native implementation allows us to remove `runOutsideAngular` calls and reduce indentation, making the code a bit more readable. I also reduced Prettier print width to 90, because 120 seems to be large (the code overlaps the editor).
arturovt
force-pushed
the
refactor/observer
branch
from
3e24b85 to
d95d0de
Compare
In this commit, we retrieve the native
IntersectionObserverimplementation hidden by__zone_symbol__IntersectionObserver. This would be the unpatched version of the observer present in zone.js environments.Otherwise, if the user is using zoneless change detection (and zone.js is not included), we fall back to the native implementation. Accessing the native implementation allows us to remove
runOutsideAngularcalls and reduce indentation, making the code a bit more readable.I also reduced Prettier print width to 90, because 120 seems to be
large (the code overlaps the editor).