Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action workflow for F5 CLA integration #754

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

TasoOneAsia
Copy link
Member

Proposed changes

An updated version of #661 that includes a GitHub action workflow integrating the F5 CLA into the typical GitHub pull-request flow for individual contributors.

As part of this workflow's configuration, the following usernames were marked as F5 maintainers:

  • lucacome
  • pleshakov

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@TasoOneAsia TasoOneAsia requested a review from a team as a code owner July 1, 2024 15:31
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 1, 2024
@lucacome lucacome requested a review from a team July 12, 2024 19:20
@lucacome
Copy link
Member

I don't know if @pleshakov still wants to be a maintainer

@TasoOneAsia
Copy link
Member Author

@lucacome I can remove him from this changeset if desired. However, there isn't much of a net-negative to being listed, all it does is prevents the bot from being implicitly triggered to prompt for a CLA upon a PR to main.

In an ideal world, the maintainer allowlist would be defined at the organization level instead of per-project, but our chosen solution does not have that functionality for the timebeing.

@lucacome
Copy link
Member

@TasoOneAsia sounds good to me to leave him there.

Is this ready to be merged?

@TasoOneAsia
Copy link
Member Author

@lucacome yup, all set on my side 👍

@lucacome lucacome changed the title ci(f5-cla): add GH action workflow for F5 CLA integration Add GitHub Action workflow for F5 CLA integration Jul 16, 2024
@lucacome lucacome enabled auto-merge (squash) July 16, 2024 20:10
@lucacome lucacome merged commit 95324ec into nginxinc:main Jul 16, 2024
15 checks passed
@TasoOneAsia TasoOneAsia deleted the ci/f5-cla-tooling branch July 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants