Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type-o #73

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Fix type-o #73

merged 1 commit into from
Nov 18, 2019

Conversation

asherf
Copy link
Contributor

@asherf asherf commented Nov 18, 2019

Proposed changes

Fixed a type-o in the metric help text/description.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

Rulox
Rulox approved these changes Nov 18, 2019
View reviewed changes
Copy link

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Dean-Coakley
Dean-Coakley approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asherf !

@Dean-Coakley Dean-Coakley merged commit 23e6c62 into nginxinc:master Nov 18, 2019
@asherf asherf deleted the typos branch November 18, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@pleshakov pleshakov Awaiting requested review from pleshakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asherf @Rulox @Dean-Coakley