Location zone and resolver metric support #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
ampant
changed the title
ampant
force-pushed
the
location/resolver-metrics
branch
from
e7594e0
to
ac03689
Compare
pleshakov
suggested changes
Oct 1, 2019
There was a problem hiding this comment.
@ampant please see my suggestions.
Additinally, please update the main readme to include the newly added metrics -- https://github.com/nginxinc/nginx-prometheus-exporter#exported-metrics
Note that currently the code doesn't work for the resolver metrics:
./nginx-prometheus-exporter -nginx.plus --nginx.scrape-uri http://demo.nginx.com/api
2019/10/01 13:43:31 Starting NGINX Prometheus Exporter Version=0.4.2 GitCommit=ac03689
panic: descriptor Desc{fqName: "nginxplus_resolver_unknown", help: "The total number of requests completed with an unknown error.", constLabels: {}, variableLabels: [resolver]} is invalid: duplicate label names
goroutine 1 [running]:
. . .
Dean-Coakley
suggested changes
Oct 11, 2019
There was a problem hiding this comment.
Some feedback from @pleshakov was missed. Please take note.
Dean-Coakley
approved these changes
Oct 14, 2019
ampant
force-pushed
the
location/resolver-metrics
branch
from
9367d21
to
048e8fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes