Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Environment Variable options to flags managed in exporter-toolkit #607

Merged
merged 9 commits into from
Jan 25, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Jan 16, 2024

Proposed changes

Adding environment variables in exporter-toolkit directly was rejected, so adding here.

LISTEN_ADDRESS=:9114 go run .                
ts=2024-01-16T09:52:54.647Z caller=exporter.go:136 level=info msg="Starting nginx-prometheus-exporter" version="(version=, branch=, revision=unknown)"
ts=2024-01-16T09:52:54.647Z caller=exporter.go:137 level=info msg="Build context" build_context="(go=go1.21.4, platform=darwin/arm64, user=, date=, tags=unknown)"
ts=2024-01-16T09:52:54.648Z caller=tls_config.go:313 level=info msg="Listening on" address=[::]:9114

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING
    guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@oseoin oseoin requested a review from a team as a code owner January 16, 2024 09:50
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jan 16, 2024
@oseoin oseoin changed the title add env var options to flags managed in exporter-toolkit Add Environment Variable options to flags managed in exporter-toolkit Jan 16, 2024
@oseoin oseoin linked an issue Jan 16, 2024 that may be closed by this pull request
exporter.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@github-actions github-actions bot added the tests Pull requests that update tests label Jan 18, 2024
@oseoin oseoin merged commit aa81230 into main Jan 25, 2024
12 checks passed
@oseoin oseoin deleted the missing-web-env-vars branch January 25, 2024 10:18
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LISTEN_ADDRESS env does not work anymore
5 participants