Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stream server zones session metrics #60

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Fix stream server zones session metrics #60

merged 2 commits into from
Jul 17, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Session 4xx and 5xx metrics were fixed in nginxinc/nginx-plus-go-client@f8b65d2.
This PR updates that dependency to that commit in order to fix the issue.

Before the fix

  • The exporter would not scrape this values correctly and would always report the metrics as 0.

After the fix

  • The exporter correctly scrapes and exports these metrics.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Jul 16, 2019
@Dean-Coakley Dean-Coakley self-assigned this Jul 16, 2019
@Dean-Coakley
Fix nginx-plus-go-client dep bug
a411ae3 
Update nginx-plus-go-client to fix stream upstreamServer metrics
pleshakov
pleshakov approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The bug affects in stream server zones sessions not stream upstream servers. Please rename the PR accordingly.

@Dean-Coakley Dean-Coakley changed the title Fix 4xx and 5xx stream upstreamServer metrics Fix 4xx and 5xx stream server zone session metrics Jul 17, 2019
@Dean-Coakley Dean-Coakley changed the title Fix 4xx and 5xx stream server zone session metrics Fix stream server zones session metrics Jul 17, 2019
@Dean-Coakley Dean-Coakley merged commit c299f20 into master Jul 17, 2019
@Dean-Coakley Dean-Coakley deleted the fix/session-stream-metrics branch July 17, 2019 19:48
@Rulox Rulox mentioned this pull request Jul 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox