Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate old flag format #460

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Deprecate old flag format #460

merged 1 commit into from
Jul 20, 2023

Conversation

lucacome
Copy link
Member

Proposed changes

Converts old flag format to new format and warns users instead of erroring out.

Closes #447

@lucacome lucacome requested a review from a team as a code owner July 19, 2023 21:44
@lucacome lucacome self-assigned this Jul 19, 2023
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 19, 2023
@lucacome lucacome merged commit 18e8f98 into main Jul 20, 2023
8 checks passed
@lucacome lucacome deleted the chore/deprecated-flags branch July 20, 2023 16:14
@lbdemv lbdemv mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI flags broken after kingpin migration
3 participants
@lucacome @vepatel @jjngx