Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nginxexporter_build_info metric #32

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Add nginxexporter_build_info metric #32

merged 1 commit into from
Jan 17, 2019

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Add nginxexporter_build_info metric
Implements #28 suggestion No 1

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto master

@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Jan 17, 2019
Dean-Coakley
Dean-Coakley reviewed Jan 17, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pleshakov pleshakov merged commit 9ee3712 into master Jan 17, 2019
@pleshakov pleshakov deleted the build-info-metric branch January 17, 2019 17:18
@pleshakov pleshakov mentioned this pull request Jan 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@isaachawley isaachawley isaachawley approved these changes

@Rulox Rulox Rulox approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pleshakov @isaachawley @Rulox @Dean-Coakley