Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement up metrics and timeout cli argument #31

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Implement up metrics and timeout cli argument #31

merged 2 commits into from
Jan 11, 2019

Conversation

pleshakov
Copy link
Contributor

@pleshakov pleshakov commented Jan 9, 2019 •
edited
Loading

Proposed changes

  • Implements Export nginx[plus]_up metric #26 - nginx_up and nginxplus_up metrics.
  • Adds -nginx.timeout cli argument for setting a timeout for scrapping metrics from NGINX or NGINX Plus.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

@pleshakov
Add up metrics
59be0a4 
Add nginx_up and nginxplus_up metrics that show the status of the
last metric scrape from NGINX or NGINX Plus.
isaachawley
isaachawley suggested changes Jan 10, 2019
View reviewed changes
Copy link

@isaachawley isaachawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scraping != scrapping, otherwise looks good.

README.md Outdated Show resolved Hide resolved
exporter.go Outdated Show resolved Hide resolved
@pleshakov
Add nginx.timeout cli argument
65bb6a5 
Add -nginx.timeout cli argument for setting a timeout for scrapping
metrics from NGINX or NGINX Plus.
@pleshakov pleshakov merged commit 4641a69 into master Jan 11, 2019
@pleshakov pleshakov deleted the up-metric branch January 11, 2019 18:01
@pleshakov pleshakov mentioned this pull request Jan 11, 2019
Closed
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaachawley isaachawley isaachawley approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleshakov @isaachawley @Dean-Coakley