Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for go 1.16 #184

Merged
merged 2 commits into from
May 6, 2021
Merged

Conversation

inosato
Copy link
Contributor

@inosato inosato commented May 1, 2021

Proposed changes

Refactor for go 1.16. ( Related PR: #160 )
I fixed 2 points.

  1. Replace io/ioutil with io or os.
    io/ioutil is "deprecated", so I replace with io or os.
    ref: https://golang.org/doc/go1.16#ioutil

    io/ioutil is unlikely to be deleted, but io or os is better.
    ref: https://twitter.com/_rsc/status/1351676094664110082

  2. Remove GO111MODULE=on
    Default value of GO111MODULE is on from go 1.16.
    So we no longer have to set this each time.
    ref: https://golang.org/doc/go1.16#modules

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

@lucacome
Copy link
Member

lucacome commented May 4, 2021

Hi @inosato thanks for the PR, looks good!

I noticed that we missed some setup steps in the workflow and I think that's why the build is failing here. I think after we merge #187 this one will be good.

@lucacome lucacome requested review from lucacome, a team and ciarams87 and removed request for a team May 4, 2021 17:04
@lucacome
Copy link
Member

lucacome commented May 5, 2021

@inosato the PR was merged, after you rebase to master the build should pass.

@inosato
Copy link
Contributor Author

inosato commented May 6, 2021

@lucacome Thank you for your response! I rebased it.

@ciarams87 ciarams87 merged commit 98798df into nginxinc:master May 6, 2021
@inosato inosato deleted the refactor_for_go1.16 branch May 6, 2021 17:20
@lucacome lucacome added the chore Pull requests for routine tasks label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants