Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for more platforms, push to Docker Hub #164

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Add support for more platforms, push to Docker Hub #164

merged 1 commit into from
Mar 19, 2021

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Mar 18, 2021 •
edited
Loading

  • Building binaries for more versions of arm, 386, ppc64le, mips64le and s390x
  • Building docker images for ARM and ppc64 (other platforms are not supported by distroless docker image)

@lucacome lucacome self-assigned this Mar 18, 2021
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 18, 2021
@lucacome lucacome changed the title Push images to Docker Hub for ARM Push images to Docker Hub for ARM and ppc64le Mar 18, 2021
Base automatically changed from chore/add-goreleaser to master March 18, 2021 23:50
@lucacome lucacome force-pushed the chore/add-docker-images-arm branch from a34a622 to 453873b Compare March 18, 2021 23:52
@lucacome lucacome force-pushed the chore/add-docker-images-arm branch 3 times, most recently from 19a9718 to 311f054 Compare March 19, 2021 01:40
@lucacome lucacome changed the title Push images to Docker Hub for ARM and ppc64le Add support for more platforms, push to Docker Hub Mar 19, 2021
@lucacome lucacome added enhancement Pull requests for new features/feature enhancements and removed chore Pull requests for routine tasks labels Mar 19, 2021
@lucacome lucacome force-pushed the chore/add-docker-images-arm branch from 311f054 to 3b5b969 Compare March 19, 2021 02:31
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 19, 2021
@lucacome lucacome removed the chore Pull requests for routine tasks label Mar 19, 2021
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 19, 2021
@lucacome lucacome force-pushed the chore/add-docker-images-arm branch 4 times, most recently from 137ad7a to 28afc07 Compare March 19, 2021 05:22
ciarams87
ciarams87 approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool - it's so easy to extend to other platforms, great work!!

@lucacome
Add support for more platforms, push to Docker Hub
2a14665 
Push ARM and ppc64 to Docker Hub
@lucacome lucacome force-pushed the chore/add-docker-images-arm branch from 28afc07 to 2a14665 Compare March 19, 2021 16:43
@lucacome lucacome merged commit 85f013d into master Mar 19, 2021
@lucacome lucacome deleted the chore/add-docker-images-arm branch March 19, 2021 16:48
@lucacome lucacome linked an issue Mar 23, 2021 that may be closed by this pull request
how to use in 'arm64' architecture? #122
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@soneillf5 soneillf5 Awaiting requested review from soneillf5

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how to use in 'arm64' architecture?
3 participants
@lucacome @pleshakov @ciarams87