Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag for controlling SSL verification of NGINX stub_status/API endpoint #13

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

razaj92
Copy link

@razaj92 razaj92 commented Sep 21, 2018

Proposed changes

Adding a flag to allow connecting to insecure TLS endpoints

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [ x ] I have read the CONTRIBUTING guide
  • [ x ] I have proven my fix is effective or that my feature works
  • [ x ] I have checked that all unit tests pass after adding my changes
  • [ x ] I have ensured the README is up to date
  • [ x ] I have rebased my branch onto master
  • [ x ] I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

@pleshakov pleshakov self-requested a review September 24, 2018 16:19
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Sep 24, 2018
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please see my comments

exporter.go Outdated Show resolved Hide resolved
@pleshakov pleshakov merged commit 4d8ada8 into nginxinc:master Sep 25, 2018
@pleshakov
Copy link
Contributor

@razaj92 thank you!

@pleshakov pleshakov changed the title add option to skip tls verify Add a flag for controlling SSL verification of NGINX stub_status/API endpoint Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants